Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

CSRF should be removed if it's disabled in forms #696

Open
jwoertink opened this issue Nov 5, 2021 · 0 comments · May be fixed by #802
Open

CSRF should be removed if it's disabled in forms #696

jwoertink opened this issue Nov 5, 2021 · 0 comments · May be fixed by #802
Labels
good first issue Good for newcomers

Comments

@jwoertink
Copy link
Member

You have the option to disable CSRF in forms with
https://github.com/luckyframework/lucky/blob/60b24a8f0489d6115063d15ba5974481b02c9abe/src/lucky/tags/form_helpers.cr#L3

If this is disabled, then we should probably also display the metatags as well.

lucky_cli/src/browser_app_skeleton/src/components/shared/layout_head.cr

Line 11 in 522c046

csrf_meta_tags

@jwoertink jwoertink added the good first issue Good for newcomers label Dec 19, 2021
@jwoertink jwoertink added the hacktoberfest Valid Issue for Hacktoberfest label Oct 1, 2022
@jwoertink jwoertink removed the hacktoberfest Valid Issue for Hacktoberfest label Nov 6, 2022
jwoertink added a commit that referenced this issue May 14, 2023
@jwoertink
If the CSRF is disabled, also remove the metatags. Fixes #696
4917817
@jwoertink jwoertink linked a pull request May 14, 2023 that will close this issue
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

If the CSRF is disabled, also remove the metatags. luckyframework/lucky_cli
1 participant
@jwoertink