Replace task code with LuckyTask #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In order for the specs to pass, Avram will have to be updated first |
|
There's one spec that uses lucky tasks so it will have to be updated as well before the last spec will pass |
jwoertink
approved these changes
Apr 6, 2021
|
@jwoertink Nope! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #620
In #621 I experimented with completely separating the CLI code from the task code but it was pointed out that we could extract a shard and that would possibly solve another problem of circular dependencies.
So I have made a LuckyTask and incorporated it into this library and removed the existing task code. This would be a bigger breaking change as we'd have to make sure we update all the places tasks are made in various libraries.