Migrate to LuckyTemplate - Part 4 of ... #810
Conversation
mdwagner
commented
Jun 25, 2023
mdwagner
commented
- Changes browser_authentication_app_skeleton to use lucky_template
| end | ||
| end | ||
| actions_dir.add_folder("mixins") do |mixins_dir| | ||
| mixins_dir.add_file(".keep") |
There was a problem hiding this comment.
Maybe we can knock out #778 too while you're in here? This issue is basically saying no .keep inside folders that will always have files generated. We can also come back to that later once everything is in place.
There was a problem hiding this comment.
The only issue I have removing .keep files are that it removes the intention of whether a particular folder structure should always exist, e.g. mixins is a folder name you expect to see in a project. Or support is a folder name you expect to see in spec. That's my opinion, otherwise I agree you don't need to include them (although, they don't cause any harm in having them).
There was a problem hiding this comment.
We could always add an option to the CLI that doesn't add those files, which seems like the better option here.
There was a problem hiding this comment.
I'm cool with that too. The files being there don't really bother me. We can just leave it for now and worry about that in a future PR.
| end | ||
|
|
||
| private def emails_folder | ||
| LuckyTemplate.create_folder do |emails_dir| |
There was a problem hiding this comment.
That's interesting that this already knows what directory its in. Pretty neat!
There was a problem hiding this comment.
It's not that it already knows, it's more that I'm making it clear that I expect it to be this way. You still need to add it to Folder#insert_folder and provide a name (which could be something other than "emails"). This is just so you can separate out the folders for better code organization or for reuse.
