Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support for browser binary setting. #59

Merged
merged 1 commit into from
Sep 10, 2019
Merged

Add support for browser binary setting. #59

merged 1 commit into from
Sep 10, 2019

Conversation

snadon
Copy link
Contributor

@snadon snadon commented Sep 10, 2019

This PR makes it possible to use another chromium-based browser instead of Google Chrome.

At the moment #capabilities is called often and we could avoid merging the settings every time start_session is called.

I'm opening this PR to see how we would like to handle this properly.

Copy link
Member

@paulcsmith paulcsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very cool and I think this is a fine way to handle it. Have you tried this out locally. This would be difficult to run automated tests on so before merging I'd like to confirm you've tested it and it works as expected

@redo-studios
Copy link

Yes I’m using it locally since yesterday. I tested with Brave. I did not try with other chromium-based browsers though.

@paulcsmith paulcsmith merged commit f7def69 into luckyframework:master Sep 10, 2019
@paulcsmith
Copy link
Member

Awesome! I think that's great! Can I ask why you used Brave? I've never used it for testing before. Is it faster/nicer?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants