Move request method matching to the bottom level instead of the top #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcsmith
approved these changes
Aug 5, 2020
paulcsmith
reviewed
Aug 5, 2020
Comment on lines
-24
to
-44
| # The matcher stores routes based on the HTTP method | ||
| # | ||
| # Each route key is a `Fragment(T)`. Where `T` is the type of the payload. See | ||
| # `Fragment` for details on how it works | ||
| # | ||
| # ## Example | ||
| # | ||
| # ``` | ||
| # router = LuckyRouter::Matcher(Symbol).new | ||
| # router.add("get", "/users/:user_id", :index) | ||
| # | ||
| # # Will make @routes look like: | ||
|
|
||
| # { | ||
| # "get" => Fragment(T) # The fragment for this route | ||
| # } | ||
| # ``` | ||
| # | ||
| # So if trying to match a POST request it will not even try because the request | ||
| # method does not match any of the known routes. | ||
| @routes = Hash(HttpMethod, Fragment(T)).new |
There was a problem hiding this comment.
If you could add a comment similar to this to help readers visualize how things are mapped to the router internals that'd be awesome. Could be done in a separate PR anytime. But this isn't a blocker so no worries if you don't have time. C
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #27
This change increases the speed of the routing library when a valid request is made.
Beyond just increasing the speed, this is another step towards a larger refactor of the internals. The big idea is to move the decision logic all into one place so that pieces can then be refactored to bring more clarity and conciseness. At this point, I do not believe that the library is any more or less clear but by moving this down into the Fragment class, we can refactor the
PartProcessorandMatchFinderclasses later on.NOTE: this is definitely a breaking change for the internal API if that is a concern
Benchmark (with
--release)