feat(core): enhance DataVault integration, certificate handling, and test suite #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added new `config.ts` for centralized configuration management - Added `check-certificates.ts` example for certificate validation - Updated API client to support certificate configuration - Enhanced `.env.sample` with certificate-related variables This improves certificate handling and provides better examples for users implementing certificate-based authentication.
- Update DataVault schemas to include required fields (channel, store) - Add proper type definitions for Create and Delete operations - Improve ProcessPaymentSchema to handle DataVault tokens correctly - Split into BasePaymentSchema, CardPaymentSchema and TokenPaymentSchema - Add proper validation for token-based payments - Update field constraints (altMerchantName: 25 chars, dataVaultToken: 36 chars) - Remove DataVaultTransaction enum in favor of literal types - Fix documentation comments and typos
- Add test card fixtures with consistent test data - Create utility functions for common test assertions: - expectSuccessfulPayment - expectSuccessfulVerification - expectSuccessfulVaultResponse - expectSuccessfulVoid - expectValidationError - expectOrderIds - Update all integration tests to use shared test cards and assertions - Add proper type guards and response type definitions - Handle temporary system errors (91) gracefully with warnings - Improve test descriptions and organization
- Create new example script for end-to-end payment processing - Demonstrate key Azul API workflows: hold, post, and verification - Include environment configuration logging and error handling - Use test card fixture and random order ID for realistic scenario
- Replace hardcoded environment variables with CONFIG import - Leverage centralized configuration for test API instance setup - Improve consistency with recent configuration management changes
- Remove test case for non-PEM certificate file - Simplify test suite by eliminating redundant error handling scenario - Maintain core certificate error testing logic
- Add environment and channel configuration options - Clarify certificate and key input methods - Update payment method example with more detailed parameters - Improve documentation for API initialization and usage
crisog
approved these changes
Jan 29, 2025
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Feel free to open a PR, I'll review & merge it 💯 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces major improvements to the core functionality and test infrastructure:
DataVault Integration
channel,store,saveToDataVaultcardNumberandexpirationwhen using tokensCertificate Management
src/config.ts:examples/check-certificates.ts)Schema Improvements
CardPaymentSchemaandTokenPaymentSchemaTest Suite Enhancements
Error Handling
Documentation
.env.samplewith certificate configurationThis update significantly improves the reliability and maintainability of the codebase, particularly in areas of DataVault integration, certificate handling, and test infrastructure.