Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Seperate log messages #42

Merged
merged 5 commits into from
Jan 11, 2019
Merged

Seperate log messages #42

merged 5 commits into from
Jan 11, 2019

Conversation

ludeeus
Copy link
Owner

@ludeeus ludeeus commented Jan 11, 2019

Added log separation in helper.py/gdh_request()

From:

except (TypeError, KeyError, IndexError) as error:
msg = "Error parsing information - {}".format(error)
log.error(msg)
except (asyncio.TimeoutError, aiohttp.ClientError, gaierror,
asyncio.CancelledError) as error:
msg = "{} - {}".format(url, error)
log.error(msg)
except Exception as error: # pylint: disable=W0703
log.error(error)

To:

except (TypeError, KeyError, IndexError) as error:
log.error("Error parsing information - {}".format(error))
except asyncio.TimeoutError:
log.error("Timeout contacting {}".format(url))
except asyncio.CancelledError:
log.error("Cancellation error contacting {}".format(url))
except aiohttp.ClientError as error:
log.error("ClientError contacting {} - {}".format(url, error))
except gaierror as error:
log.error("I/O error contacting {} - {}".format(url, error))
except Exception as error: # pylint: disable=W0703
log.error("Unexpected error contacting {} - {}".format(url, error))

@ludeeus ludeeus merged commit 5bab514 into master Jan 11, 2019
@delete-merged-branch delete-merged-branch bot deleted the catch-timeout-seperatly branch January 11, 2019 12:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants