Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Ignore empty lines and comments in env files #531

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

greghaygood
Copy link
Contributor

As noted in #522, .env files with blank lines or comments are no longer being ignored. This PR updates that. HTH!

@height
Copy link

height bot commented Nov 25, 2020

Link Height tasks by mentioning a task ID in the pull request title or description, commit messages, or comments.

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link
Collaborator

@luancurti luancurti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense. Thank you!

@luancurti luancurti merged commit caecb14 into lugg:master Nov 25, 2020
@rborn
Copy link

rborn commented Nov 27, 2020

@luancurti Release so we don't have to go with master in package.json ? 😻 works great btw :)

@NetPumi2
Copy link

Lifesaver, it works thx

@aaronfg
Copy link

aaronfg commented Dec 11, 2020

Just updated to 1.4.1 and had this exact problem since I have comment lines in my env file.

Glad this PR was made and approved. Waiting on this to be in a new release.

@AlexandreLage
Copy link

Is this on release already?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants