Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

tests: test string variadic group w/ actual variable string args #30

Merged
merged 2 commits into from
Mar 19, 2021

Conversation

gingerrific
Copy link
Contributor

@gingerrific gingerrific commented Mar 19, 2021

I noticed that the strings (variadic) section of the tests were actually redundant with the single argument tests. I updated them to include variable numbers of string args.

Copy link
Owner

@lukeed lukeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, nice find. Thanks!

@lukeed lukeed merged commit 74cefa6 into lukeed:master Mar 19, 2021
@gingerrific
Copy link
Contributor Author

@lukeed haha, good fix :) I was apparently a little too excited to help

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants