-
-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
♻️ Remove legacy start column #1113
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Warning Rate Limit Exceeded@lukevella has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 36 minutes and 58 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThis update primarily focuses on renaming the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (7)
- apps/web/src/components/poll/manage-poll/finalize-poll-dialog.tsx (1 hunks)
- apps/web/src/components/scheduled-event.tsx (1 hunks)
- apps/web/src/contexts/current-event.ts (1 hunks)
- apps/web/src/utils/trpc/types.ts (1 hunks)
- packages/backend/trpc/routers/polls.ts (9 hunks)
- packages/database/prisma/migrations/20240317095541_remove_legacy_start_column/migration.sql (1 hunks)
- packages/database/prisma/schema.prisma (1 hunks)
Files skipped from review due to trivial changes (3)
- apps/web/src/contexts/current-event.ts
- apps/web/src/utils/trpc/types.ts
- packages/database/prisma/migrations/20240317095541_remove_legacy_start_column/migration.sql
Additional comments not posted (2)
packages/database/prisma/schema.prisma (1)
Line range hint
33-33
: Confirm removal ofstart
field and addition ofstartTime
.The changes correctly reflect the migration from
start
tostartTime
in theOption
model.packages/backend/trpc/routers/polls.ts (1)
380-380
: Ensure theorderBy
clause usesstartTime
.The change to use
startTime
in theorderBy
clause of thelist
query is correctly implemented.
Summary by CodeRabbit
New Features
Bug Fixes
start
tostartTime
in various components for consistency.Chores
start
column from the database schema.Refactor
useCurrentPollOptions
function from the current event context.