Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Removed database port number from docker-compose.yml DATABASE_URL #1132

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

dahlo
Copy link
Contributor

@dahlo dahlo commented May 29, 2024

Description

As @tomquas pointed out in #1079, having the port number specified in the DATABASE_URL variable causes the rallly_selfhosted container not being able to connect to the rallly_db container. docker-compose up fails with the message

Error: P1001: Can't reach database server at "rallly_db:5450"

as it seems to think :5450 is part of the hostname. Removing it solves the issue and the containers start as expected.

Checklist

Please check off all the following items with an "x" in the boxes before requesting a review.

  • I have performed a self-review of my code
  • My code follows the code style of this project
  • I have commented my code, particularly in hard-to-understand areas

Summary by CodeRabbit

  • Chores
    • Updated database connection configuration in docker-compose.yml by removing the port number from the DATABASE_URL environment variable. This may affect how the app connects to the database.

Copy link

vercel bot commented May 29, 2024

@dahlo is attempting to deploy a commit to the rallly Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented May 29, 2024

Warning

Review failed

The pull request is closed.

Walkthrough

The DATABASE_URL environment variable in the docker-compose.yml file has been updated to remove the port number 5450 from the database connection string. This change affects how the application connects to the database, potentially simplifying the connection configuration.

Changes

File Change Summary
docker-compose.yml Modified DATABASE_URL environment variable to remove port number 5450 from the connection string.

Poem

Amidst the code, a change so neat,
The port was dropped, connection sweet.
No more 5450 in our URL,
A simpler path, where data dwell.
🐇✨ The bunnies cheer, with hops so high,
For cleaner code beneath the sky! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 12d273c and b7d2d84.
Files selected for processing (1)
  • docker-compose.yml (1 hunks)
Additional comments not posted (1)
docker-compose.yml (1)

31-31: Change looks good and aligns with the PR's objective to fix the connection issue.

@lukevella
Copy link
Owner

Thanks @dahlo. I had to resolve some conflicts due to some recent changes but otherwise this looks good to me 👍

@lukevella lukevella merged commit cf0e124 into lukevella:main Jun 10, 2024
5 of 7 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants