-
-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Removed database port number from docker-compose.yml DATABASE_URL #1132
Conversation
@dahlo is attempting to deploy a commit to the rallly Team on Vercel. A member of the Team first needs to authorize it. |
Warning Review failedThe pull request is closed. WalkthroughThe Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- docker-compose.yml (1 hunks)
Additional comments not posted (1)
docker-compose.yml (1)
31-31
: Change looks good and aligns with the PR's objective to fix the connection issue.
Thanks @dahlo. I had to resolve some conflicts due to some recent changes but otherwise this looks good to me 👍 |
Description
As @tomquas pointed out in #1079, having the port number specified in the
DATABASE_URL
variable causes therallly_selfhosted
container not being able to connect to therallly_db
container.docker-compose up
fails with the messageError: P1001: Can't reach database server at "rallly_db:5450"
as it seems to think
:5450
is part of the hostname. Removing it solves the issue and the containers start as expected.Checklist
Please check off all the following items with an "x" in the boxes before requesting a review.
Summary by CodeRabbit
docker-compose.yml
by removing the port number from theDATABASE_URL
environment variable. This may affect how the app connects to the database.