Fix event ICS download button file content

[smncd]

Solves #1389:

Summary:
The content of the ICS file generated by the download button in apps/web/src/components/add-to-calendar-button.tsx is URL-encoded, preventing it from being imported into calendar apps. This PR fixes this.

Summary by CodeRabbit

• New Features
  • Improved the ICS file download functionality for the Add to Calendar button, streamlining the process for users.
  • Continued support for adding events to Google Calendar, Microsoft 365, Outlook, and Yahoo.

[vercel]

@smncd is attempting to deploy a commit to the rallly Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

Walkthrough

The AddToCalendarButton component has been updated to enhance the ICS file download functionality. The variable used to store the result of the ics(calendarEvent) function has been changed from res to data. The previous method of creating a Blob object and generating a URL from it has been removed, streamlining the download process. The component's structure, props, and rendering logic for calendar service options remain unchanged.

Changes

File Path	Change Summary
apps/web/src/components/add-to-calendar-button.tsx	Updated ICS file download handling by replacing res with data and removing Blob creation.

Possibly related PRs

• fix ics download button #1381: The changes in this PR directly relate to the AddToCalendarButton component, specifically addressing the functionality of the ICS file download, which is a key aspect of the main PR's modifications.

Poem

In the garden where calendars bloom,
A button now dances, dispelling the gloom.
With a click, the events take flight,
Downloading ICS with pure delight!
No more blobs, just data so bright,
A hop and a skip, all feels just right! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 11, 2024 4:37pm
landing	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 11, 2024 4:37pm

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

apps/web/src/components/add-to-calendar-button.tsx (1)

122-126: Approved: ICS file download issue resolved

The changes successfully address the PR objective by directly setting the ICS file content to the href attribute, which should resolve the compatibility issue with calendar applications.

However, I have a few suggestions to improve the code further:

1. Consider adding error handling for potential issues with the ics() function:

try {
  const data = ics(calendarEvent);
  if (!data) {
    throw new Error("Failed to generate ICS data");
  }
  // ... rest of the code
} catch (error) {
  console.error("Error generating ICS file:", error);
  // Handle the error (e.g., show an error message to the user)
}

2. Verify that the ics() function's return type is always a string in the correct format for direct assignment to href. If not, additional processing might be needed.

3. For better readability, consider extracting the file download logic into a separate function:

const downloadIcsFile = (data: string, filename: string) => {
  const link = document.createElement("a");
  link.href = data;
  link.download = filename;
  document.body.appendChild(link);
  link.click();
  document.body.removeChild(link);
};

// In the onClick handler:
const data = ics(calendarEvent);
const filename = `${title.toLowerCase().replace(/\s/g, "-")}.ics`;
downloadIcsFile(data, filename);

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between e592484 and 863b26e.

📒 Files selected for processing (1)

• apps/web/src/components/add-to-calendar-button.tsx (1 hunks)

🧰 Additional context used

[lukevella]

Nice work @smncd! Thanks for the fix 🙏

[smncd]

Nice work @smncd! Thanks for the fix 🙏

Happy to help @lukevella! 🥳