Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

🩹 Make email placeholders RFC 2606 compliant #622

Merged
merged 4 commits into from
Mar 30, 2023

Conversation

peterlewis
Copy link
Contributor

Description

Firstly, thank you! This project is AMAZING!

I'm submitting a change to make all email placeholders RFC 2606 compliant by using example.com as the email domain.

Checklist

Please check off all the following items with an "x" in the boxes before requesting a review.

  • I have performed a self-review of my code
  • My code follows the code style of this project
  • I have commented my code, particularly in hard-to-understand areas

@vercel
Copy link

vercel bot commented Mar 29, 2023

@peterlewis is attempting to deploy a commit to the rallly Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Mar 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
web ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 30, 2023 at 8:34AM (UTC)

@lukevella lukevella changed the title Make email placeholders RFC 2606 compliant 🩹 Make email placeholders RFC 2606 compliant Mar 29, 2023
@lukevella
Copy link
Owner

Hey @peterlewis, thanks for pointing this out. I didn't know about this RFC but it makes sense. The failing tests are due to the placeholder being used as a locator. It should be fixable with a quick find and replace :)

@peterlewis
Copy link
Contributor Author

No worries, thank YOU for making such an awesome project! Aha, that explains it. I've run a find and replace in test dir, which hopefully will have the necessary effect...

@lukevella
Copy link
Owner

Thanks @peterlewis, there seems be some issue with github actions. Going to wait for this to be resolved and then I'll go ahead and merge this.

@lukevella
Copy link
Owner

Hey @peterlewis, unfortunately the workflow for this PR is stuck in the queue. Would you be able to close this an open a new PR?

Changed `availble` to `available` in the hope that it re-triggers the stuck GitHub action! :)
@peterlewis
Copy link
Contributor Author

Hey @peterlewis, unfortunately the workflow for this PR is stuck in the queue. Would you be able to close this an open a new PR?

Yeah still appears stuck... :-/ I've added a cheeky typo fix to this PR in the hope that it re-triggers the GitHub Actions!

@lukevella lukevella enabled auto-merge (squash) March 30, 2023 08:35
@lukevella lukevella merged commit e219491 into lukevella:main Mar 30, 2023
@peterlewis peterlewis deleted the rfc2606 branch March 30, 2023 08:37
@peterlewis
Copy link
Contributor Author

Looking good, thanks for the merge... :)

@lukevella
Copy link
Owner

Looking good, thanks for the merge... :)

Yes, thanks for your help! 👍

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants