-
-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
🩹 Make email placeholders RFC 2606 compliant #622
Conversation
@peterlewis is attempting to deploy a commit to the rallly Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hey @peterlewis, thanks for pointing this out. I didn't know about this RFC but it makes sense. The failing tests are due to the placeholder being used as a locator. It should be fixable with a quick find and replace :) |
No worries, thank YOU for making such an awesome project! Aha, that explains it. I've run a find and replace in test dir, which hopefully will have the necessary effect... |
Thanks @peterlewis, there seems be some issue with github actions. Going to wait for this to be resolved and then I'll go ahead and merge this. |
Hey @peterlewis, unfortunately the workflow for this PR is stuck in the queue. Would you be able to close this an open a new PR? |
Changed `availble` to `available` in the hope that it re-triggers the stuck GitHub action! :)
Yeah still appears stuck... :-/ I've added a cheeky typo fix to this PR in the hope that it re-triggers the GitHub Actions! |
Looking good, thanks for the merge... :) |
Yes, thanks for your help! 👍 |
Description
Firstly, thank you! This project is AMAZING!
I'm submitting a change to make all email placeholders RFC 2606 compliant by using example.com as the email domain.
Checklist
Please check off all the following items with an "x" in the boxes before requesting a review.