Unit tests #4
Merged
Unit tests #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skimaharvey
force-pushed
the
unit-tests
branch
from
fdcc4db to
bbaf719
Compare
CJ42
approved these changes
Oct 18, 2024
| @@ -1,2 +1,2 @@ | |||
| @/=node_modules/@ | |||
| forge-std/=node_modules/forge-std/ | |||
There was a problem hiding this comment.
Looks like this remapping is mentioned twice, in foundry.toml as well. Suggest keeping it only in one place
test/HypLSP7.t.sol
Outdated
|
|
||
| HypLSP7 internal lsp7Token; | ||
|
|
||
| address internal owner = makeAddr("owner"); |
There was a problem hiding this comment.
This address is defined twice. Suggest removing this state variable and using the one above
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR introduce?