You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
OdinsonIndexReader should have a helper method (ex. deleteBlockByParentId) to delete a block of documents (sentences) from the index based on the Lucene doc ID of a block's parent (relates to OdinsonDocumentIndexReader.reader.deleteDocument()).
Issues
Deleting an OdinsonDocument should mean removing all Lucene documents created from that OdinsonDocument.
OdinsonIndexWriter.mkNestedDocument() creates a Lucene document, but that document does not include a field with OdinsonIndexWriter.DOC_ID_FIELD. This makes it easy to overlook when sweeping for all Lucene docs created from an OdinsonDocument.
The text was updated successfully, but these errors were encountered:
Currently, there is not an easy way to delete an
OdinsonDocument
from an index. We should add support for deleting a block of documents (sentences).Proposal
OdinsonIndex.indexOdinsonDoc
and its implementations should return the Lucene doc ID of the block's parent.IncrementalOdinsonIndex.indexOdinsonDoc
OdinsonIndexReader
should have a helper method (ex.deleteBlockByParentId
) to delete a block of documents (sentences) from the index based on the Lucene doc ID of a block's parent (relates toOdinsonDocumentIndexReader.reader.deleteDocument()
).Issues
OdinsonDocument
should mean removing all Lucene documents created from thatOdinsonDocument
.OdinsonIndexWriter.mkNestedDocument()
creates a Lucene document, but that document does not include a field withOdinsonIndexWriter.DOC_ID_FIELD
. This makes it easy to overlook when sweeping for all Lucene docs created from anOdinsonDocument
.The text was updated successfully, but these errors were encountered: