Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Unpin cliargs dependency #733

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

alerque
Copy link
Member

@alerque alerque commented Dec 12, 2023

I haven't looked into why this was pinned in the first place yet, but whatever the reason I think we need to fix it at the source, not this way. This is making it hard to even test the cliargs module, much less release it.

@alerque alerque changed the title fix(rockspec): Unpit cliargs dependency Unpin cliargs dependency Dec 12, 2023
@alerque
Copy link
Member Author

alerque commented Dec 12, 2023

This hard pinning of versions goes back all the way to 02f26cd and has no apparent rational there either.

@alerque alerque requested a review from Tieske December 12, 2023 13:35
@alerque alerque enabled auto-merge (rebase) December 12, 2023 13:37
@rautyrauty
Copy link

@alerque merge pls

@SlySven
Copy link

SlySven commented Oct 21, 2024

This is now a breaking issue as lua_cliargs has had a patch level revision:

stephen@Ripley:~/src/mudlet$ luarocks list --local  --outdated

Outdated rocks:
---------------

lua_cliargs
   3.0-2 < 3.0.2-1 at https://luarocks.org

stephen@Ripley:~/src/mudlet$ luarocks install --local lua_cliargs
Installing https://luarocks.org/lua_cliargs-3.0.2-1.src.rock

lua_cliargs 3.0.2-1 depends on lua >= 5.1 (5.1-1 provided by VM)
lua_cliargs 3.0.2-1 is now installed in /home/stephen/.luarocks (license: MIT)

Checking stability of dependencies in the absence of
lua_cliargs 3.0-2...

Will not remove lua_cliargs 3.0-2.
Removing it would break dependencies for: 
busted 2.2.0-1

Use --force to force removal (warning: this may break modules).

stephen@Ripley:~/src/mudlet$

@hishamhm
Copy link
Member

This is now a breaking issue as lua_cliargs has had a patch level revision:

This was not an error message; it kept both versions 3.0-2 and 3.0.2-1 around in your system because of the pinned dependency.

Use --force to force removal (warning: this may break modules).

The warning was relative using to --force to remove the old one, in case that wasn't clear.

@alerque I have no idea why that was pinned. Should be safe to unpin.

@alerque alerque merged commit 0963239 into lunarmodules:master Oct 22, 2024
@alerque alerque deleted the unpin-cliargs branch October 22, 2024 13:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants