chore(build) add define to build without expat_config.h #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for #32
When building the lib and the header
expat_config.h
is not being found, then the system is missing an important header. The settings in that header file can change the ABI of the compiled lib, hence the header is required to have.Since on some systems/package managers the header is not included here's a workaround;
LUAEXPAT_SKIP_DTD_SUPPORT
andXML_DTD
(include DTD support)LUAEXPAT_SKIP_DTD_SUPPORT
(disable DTD support)To build with LuaRocks you need to pull a trick since LuaRocks does not have a way to pass the defines via the command line. Instead you can override the
CC
setting and include the defines, like this:luarocks install luaexpat CC="gcc -DLUAEXPAT_SKIP_DTD_SUPPORT -DXML_DTD"