This repository has been archived by the owner on Jun 15, 2019. It is now read-only.
Fix headers and lists #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Mind if I ask what the status on this is, @lunny? Do you need someone else to do code review? Or is there something that was preventing it from being merged? Happy to help if I can! |
|
@patcon sorry to forget this PR. |
|
No worries! Thanks a billion for everything. That library is rad |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed two issues in html2md:
<h3>) contains any new lines in its body, it will split the header contents over multiple lines, breaking the header in Markdown (because in Markdown, a header just starts with#'s and anything on the next line is not part of the header). Since in HTML and Markdown all white space is treated the same, I chose to replace line endings with spaces<li>) ends with a white space (eg. tab or space), the newline at the end will be removed from the output, causing the next list item or next element to appear on the same line.