Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add support for macOS accent color #3193

Closed
wants to merge 1 commit into from

Conversation

volskaya
Copy link

Adds an option to appearances to highlight ThumbnailView background with macOS accent color instead of the default black, while they're using the macOS theme.

In the picture it's using the hidden iMac purple accent that everyone can unlock with:
defaults write -g NSColorSimulateHardwareAccent -bool YES
defaults write -g NSColorSimulatedHardwareEnclosureNumber -int 7

@lwouis
Copy link
Owner

lwouis commented Feb 21, 2024

Hi @volskaya,

This is an interesting idea. Thank you for sharing a PR.

People have been asking to customize highlight color for a long time. Here's my opinion on it.

I'm afraid I can't merge this PR for a few reasons:

  • When changing the accent color, the default command+tab macOS app-switcher doesn't change its highlight color. AltTab is always trying to stay close to the default app-switcher, so it feels native, and almost looks like Apple made it.
  • A user may want to use the accent color, but they also want another color. Letting the user pick a color from a color picker here seems like a more open approach. People could pick what they like. See my comments above on limitations of that approach.
  • It adds yet another toggle box in the preferences. We are trying currently to reduce their number (see Simplifying the preferences UI #351).

I'm sorry to not merge the PR. I hope you understand the contraints we're in.

Thank you 🙇‍♂️

@lwouis lwouis closed this Feb 21, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants