Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Test latest lychee version tag #236

Merged
merged 7 commits into from
Oct 7, 2024
Merged

Test latest lychee version tag #236

merged 7 commits into from
Oct 7, 2024

Conversation

mre
Copy link
Member

@mre mre commented Aug 20, 2024

In the near future, we'll allow users to specify a latest tag as the lychee version.
Related issues: lycheeverse/lychee#1463

This adds a test to make sure this behavior doesn't change in the future.
The build will only succeed once we released a new version of lychee, which is why this remains in draft.

@dscho @axel-kah fyi

@mre mre marked this pull request as draft August 20, 2024 15:11
@mre mre marked this pull request as ready for review October 7, 2024 09:28
@mre mre force-pushed the latest-lychee-version branch from 31a26e9 to 25d273c Compare October 7, 2024 11:26
@mre mre merged commit 7da8ec1 into master Oct 7, 2024
4 checks passed
@mre mre deleted the latest-lychee-version branch October 7, 2024 14:41
@mre
Copy link
Member Author

mre commented Oct 7, 2024

Not 100% happy with this code as there are now a lot of branches, but I thought it's better to have this in than dwell on it too much.

Maybe it was unnecessary to change the lychee release tag names (lychee-vX.Y.Z and lychee-lib-vX.Y.Z), but I can see the advantages of having a separate release process for both, and it's the default for release-plz. On the other side, it causes a bit of churn with the release names now, but I'd say the benefits outweigh the downsides.

@bedroesb
Copy link

bedroesb commented Oct 8, 2024

Looking forward to a new release of lycheeverse/lychee-action !

@mre
Copy link
Member Author

mre commented Oct 8, 2024

New release v2.0.0 is out. Thanks for the reminder. 😄

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants