Fix retries

[trask]

I'm not seeing any retries.

I'm very new to rust, so probably missing how it's supposed to work, but this change made retries work for me.

[mre]

Thanks for the PR! Makes sense.
Can you add a test to check that it works?
Ideally, a unit test in the same file and an integration test in https://github.com/lycheeverse/lychee/blob/master/lychee-bin/tests/cli.rs. The integration test can be modeled after the existing tests. For example, you can use a mock http server as in this test:

lychee/lychee-bin/tests/cli.rs

Lines 547 to 557 in 10056dc

	#[tokio::test]
	async fn test_stdin_input_failure() {
	let mut cmd = main_command();
	let mock_server = mock_server!(StatusCode::INTERNAL_SERVER_ERROR);
	cmd.arg("-")
	.write_stdin(mock_server.uri())
	.assert()
	.failure()
	.code(2);
	}

The unit test would be about creating a new status object and checking that it returns the correct result when calling should_retry() on it. For some reason, we don't have unit tests for that yet (hence why it's probably broken), but it's a great opportunity to change that. 😉

[trask]

unit test and integration test added!

[mre]

Brilliant! Thanks for the quick turnaround and for the clean implementation.