This repository has been archived by the owner on Feb 14, 2025. It is now read-only.
Use revert endpoint for reverting service and add metadata only fetch #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also found a bug in displaying conflicts in the history revert view, which I fixed by adding getCredentialByID and getBlindCredentialByID |
skiptomyliu
reviewed
Dec 6, 2019
confidant/public/modules/history/controllers/BlindCredentialHistoryCtrl.js
Show resolved
Hide resolved
skiptomyliu
reviewed
Dec 6, 2019
skiptomyliu
previously approved these changes
Dec 6, 2019
skiptomyliu
approved these changes
Dec 6, 2019
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is aimed at returning less credential data, when that data is not necessary. Specifically, it's aiming to remove the return of full credential data when services are fetched through the interface, since those interfaces don't need the credential data.
Along with this change is a new method of doing reverts. I'm starting with service, because it's simpler, but future changes will also make this the method for credentials and blind_credentials, which will let us do reverts without needing to see values.