This repository has been archived by the owner on Feb 14, 2025. It is now read-only.
Add permission hints to responses and update UI to use them #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skiptomyliu
reviewed
Jan 10, 2020
| @@ -32,6 +35,26 @@ def get_client_config(): | |||
| ''' | |||
| Get configuration to help clients bootstrap themselves. | |||
| ''' | |||
| permissions = { | |||
There was a problem hiding this comment.
ah nice, if I understand correctly, we may be able to leverage this later to save us some RBAC API calls by storing these default permissions once the user logs in.
There was a problem hiding this comment.
@skiptomyliu yeah, these are the "global" permissions that apply to all views.
skiptomyliu
approved these changes
Jan 10, 2020
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds permissions hints for the UI, so that we can change the UI behavior based on the permissions available to the end-user.