Support ssh-ed25519 key format #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI failure seems to be a CI problem, not a problem with the code... |
|
Is there any reason why this can't be merged? We ran into the above mentioned problem. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Netflix/bless#74 got merged and clients 7.8 have problems connecting to servers <7.8:
https://bugzilla.redhat.com/show_bug.cgi?id=1623929
https://bugs.archlinux.org/task/59838
https://bugs.launchpad.net/ubuntu/+source/openssh/+bug/1790963
And that no solution seems to be on the horizon to resolve this backward compatibility issue, now might be the right time to support ed25519 key signing which, fortunately, is not very difficult on the client side.
This PR does not inclue suggesting that ed25519 should the default in README.md as this would be providing advice on the cryptographic methods.