Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: IndexingMath, Proxy, Migratable #38

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

deluca-mike
Copy link
Collaborator

@deluca-mike deluca-mike commented Oct 30, 2024

No description provided.

@deluca-mike deluca-mike added the enhancement New feature or request label Oct 30, 2024
@deluca-mike deluca-mike self-assigned this Oct 30, 2024
Copy link

github-actions bot commented Oct 30, 2024

Changes to gas cost

Generated at commit: c9a8442872d1cf483c3a389096f9e23b76189af8, compared to commit: f337029305a0af9e02893fb50897f1837c877b7b

🧾 Summary (20% most significant diffs)

Contract Method Avg (+/-) %
ERC20ExtendedHandler mint
transferFrom
-378 ✅
+166 ❌
-0.52%
+0.30%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
ERC20ExtendedHandler 1,407,239 (0) approve
burn
mint
transfer
transferFrom
32,919 (-12)
43,981 (0)
688 (0)
790 (0)
899 (0)
-0.04%
0.00%
0.00%
0.00%
0.00%
52,675 (+42)
46,229 (+15)
72,346 (-378)
55,485 (+2)
55,632 (+166)
+0.08%
+0.03%
-0.52%
+0.00%
+0.30%
52,903 (-12)
46,311 (0)
67,401 (-6)
55,553 (0)
56,012 (-12)
-0.02%
0.00%
-0.01%
0.00%
-0.02%
53,227 (0)
54,897 (+1,496)
101,847 (0)
127,389 (0)
128,189 (+71,966)
0.00%
+2.80%
0.00%
0.00%
+128.00%
1,297 (+10)
1,280 (+47)
1,298 (+30)
1,299 (-7)
1,251 (-80)
ContractHelperHarness 439,005 (0) getContractFrom 1,938 (0) 0.00% 2,154 (+2) +0.09% 2,175 (0) 0.00% 2,222 (0) 0.00% 269 (0)
SignatureCheckerHarness 1,018,085 (0) isValidSignature
recoverECDSASigner(bytes32,bytes32,bytes32)
3,617 (0)
1,549 (0)
0.00%
0.00%
6,195 (-1)
5,324 (-1)
-0.02%
-0.02%
6,175 (0)
5,330 (0)
0.00%
0.00%
11,222 (0)
5,350 (0)
0.00%
0.00%
532 (0)
259 (0)
VoidDeployer 131,091 (+12)
AccountWithFunctionReturningTrue 205,618 (-12)
UIntMathHarness 812,013 (-12)

Copy link

github-actions bot commented Oct 30, 2024

LCOV of commit 3ca08f4 during Forge Coverage #117

Summary coverage rate:
  lines......: 82.5% (146 of 177 lines)
  functions..: 85.3% (58 of 68 functions)
  branches...: no data found

Files changed coverage rate:
                               |Lines       |Functions  |Branches    
  Filename                     |Rate     Num|Rate    Num|Rate     Num
  ===================================================================
  src/ERC20Extended.sol        |95.7%     23| 100%    10|    -      0
  src/ERC3009.sol              | 100%     35| 100%    11|    -      0
  src/ERC712Extended.sol       |96.0%     25| 100%     9|    -      0
  src/Migratable.sol           | 0.0%     10| 0.0%     3|    -      0
  src/Proxy.sol                | 0.0%     11| 0.0%     1|    -      0
  src/libs/Bytes32String.sol   | 100%      8| 100%     2|    -      0
  src/libs/ContractHelper.sol  | 100%      1| 100%     1|    -      0
  src/libs/IndexingMath.sol    | 0.0%      8| 0.0%     6|    -      0
  src/libs/SignatureChecker.sol| 100%     33| 100%     8|    -      0
  src/libs/UIntMath.sol        | 100%     23| 100%    17|    -      0

src/ERC20Extended.sol Outdated Show resolved Hide resolved
@deluca-mike deluca-mike force-pushed the feat/indexing-math-proxy-migratable branch from 0af3a3e to f5695ef Compare October 30, 2024 18:47
Base automatically changed from fix/deadline-natspec to main October 30, 2024 18:47
@deluca-mike deluca-mike force-pushed the feat/indexing-math-proxy-migratable branch from f5695ef to 3ca08f4 Compare October 30, 2024 18:49
@toninorair toninorair merged commit c995528 into main Oct 30, 2024
2 checks passed
@toninorair toninorair deleted the feat/indexing-math-proxy-migratable branch October 30, 2024 19:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants