-
Notifications
You must be signed in to change notification settings - Fork 34
Support disabling default front matter and add support for Templater #119
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some review notes that need to be resolved before I can merge this PR.
The major problem I see is that compromised data in one of the APIs can result in arbitrary JS being run on the user's computer.
I have resolved all your comments. I agree with the part about code execution. The simpler solution was to shift the heavy lifting and ensure reliability through the Templater plugin. Now, it adds a Please let me know if any comment that I marked as resolved is not satisfactorily addressed, and I will gladly make the necessary corrections. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks better :)
There is still one more thing that I would change.
Tie all the templater stuff to it's own setting so that the usage of templater is independent of the "Use default front matter" setting, This setting should mention that it needs templater and make the user aware of the security risk that comes with using it.
Done! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
can you resolve the conflicts? Then i will merge |
Rebased and ready to merge. (Fixed a typing error in the latest commit) |
These changes should be completely backwards compatible. The goal of this pull request is to make Media DB more compatible with the Book Search plugin and other plugins. Additionally, to provide a more streamlined and unified way for templating.
Closes: #91
Changes:
Example of usage of changes:
movie.md (template)
Resulting markdown: Stalker (1979).md