Update Gem to Address Moneybird API Warning Responses #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing resource attributes added: - archived - contact_people - moneybird_payments_mandate
Missing resource attribute added: mandatory_tax_text
Missing resource attributes added: - contact_person - contact_person_id - next_reminder - original_estimate_id - public_view_code_expires_at - reminder_count - short_payment_reference
Missing resource attribute added: country
|
Thank you, ideally the test fixtures should also be updated but that's not necessary right now. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the gem to address Moneybird's recent API warnings encountered during interactions.
The resource classes
TaxRate,Contact,SalesInvoice, andInvoice::Detailswere changed to add the missing attributes following the latest Moneybird API specifications to prevent warning messages.Below are the attributes added:
Additional Notes
Changes should be backward compatible with previous versions of the gem (only additions, no attributes was removed)
All modifications have been tested locally to ensure functionality with the updated Moneybird API.
Further testing from other integrations is recommended to validate changes before deployment.