feat: set project capacity with async #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xudafeng
reviewed
Sep 17, 2019
app/controller/api/project.js
Outdated
| const readableSize = bufSize >= 1024 ? | ||
| `${(bufSize / 1024).toFixed(2)}KB` : | ||
| `${bufSize}B`; | ||
| const readableSize = bufSize >= 1024 * 1024 ? |
app/router.js
Outdated
| @@ -24,6 +24,7 @@ module.exports = app => { | |||
| router.get('/notfound', controller.page.notfound); | |||
|
|
|||
| router.get('/api/project', controller.api.project.showAll); | |||
| router.get('/api/project/capacity', controller.api.project.capacity); | |||
Codecov Report
@@ Coverage Diff @@
## master #147 +/- ##
==========================================
- Coverage 93.27% 91.63% -1.64%
==========================================
Files 40 40
Lines 877 885 +8
==========================================
- Hits 818 811 -7
- Misses 59 74 +15
Continue to review full report at Codecov.
|
xudafeng
reviewed
Sep 18, 2019
| @@ -3,6 +3,7 @@ language: node_js | |||
| node_js: | |||
| - '8' | |||
| install: | |||
| - rm -rf node_modules | |||
There was a problem hiding this comment.
昨天 npminstall 在 ci 一直报权限问题，删掉就可以了
xudafeng
reviewed
Sep 18, 2019
|
|
||
| item.capacity = { | ||
| count: iterfaceList.length, | ||
| size: readableSize, | ||
| size: filesize, |
There was a problem hiding this comment.
是这个 filesize https://www.npmjs.com/package/filesize
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.