New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

slug(): partial optimizations + fix PHP 8.1 #64

Merged

maciejczyzewski merged 2 commits into master from slug/minor-optimization

Jan 10, 2022

Collaborator

allejo commented Jan 9, 2022

When using __::slug() on ASCII string, it's a waste to have to call mb_ functions so instead just use normal string functions
Add a workaround for PHP 8.1 (see: mb_convert_encoding returns empty string since PHP 8.1.0 php/php-src#7898)


          slug(): partial optimizations + fix PHP 8.1

33300cf

allejo requested review from maciejczyzewski and MonsieurV

January 9, 2022 07:03


          Update CHANGELOG with __::slug() updates

c299a18

MonsieurV approved these changes

View reviewed changes

maciejczyzewski approved these changes

View reviewed changes

maciejczyzewski merged commit d9c1334 into master

allejo deleted the slug/minor-optimization branch

January 10, 2022 16:50

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet