-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore(ci): improving CI #301
Conversation
* chore(ci): reorganize CI * fix(ci): add rustfmt component * chore(ci): add benchmarks * try(ci): fixing ? * fix(ci): indent * fix(ci): trying :( * fix(ci): caching and cat * fix(ci): echo pwd * fix(ci): try ... * chore(ci): run on head and on base * fix(ci): git checkout manually * chore(ci): update benches * chore(ci): fix * fix(ci): checkout base actually * fix(ci): use checkout action
Thanks @jeertmans! I'll have a proper look at this hopefully later today. I'm trying to manage my time a bit better, and I'm thinking about carving out one day a week for a general maintenance sweet across my crates, tentatively looking at Fridays. I reckon the pace being slow here will be much more manageable if it's at least predictable. |
No problem @maciejhirsz |
* chore(codegen): error to prevent undesired behavior * chore(deps): add lazy static * chore(codegen): apply suggested changes
* it's -> its * Update internal.rs * Update lexer.rs * Update lib.rs
* chore(ci): reorganize CI * fix(ci): add rustfmt component * chore(ci): add benchmarks * try(ci): fixing ? * fix(ci): indent * fix(ci): trying :( * fix(ci): caching and cat * fix(ci): echo pwd * fix(ci): try ... * chore(ci): run on head and on base * fix(ci): git checkout manually * chore(ci): update benches * chore(ci): fix * fix(ci): checkout base actually * fix(ci): use checkout action
Results for before/after changes on applying clippy's suggestions
ConclusionIt did not affect performances (as expected). |
@jeertmans, I'm merging this in the hope it will accelerate developing the book and the "new" Logos, thanks to a better test-suite. If you are okay with test coverage, you still need to setup (free) the codecov app:
Once done, we can add a badge on the README. |
Hello @maciejhirsz,
This PR proposes new changes regarding continuous integration tests, that I think should facilitate maintaining this project.
Here are the main advantages:
clearcache.yml
);A few remarks:
Do no hesitate to give your opinion on this :-)