Reimplement mackerel_aws_integration resource with terraform-plugin-framework

[tosuke]

Part of #243

Output from acceptance testing:

$ MACKEREL_EXPERIMENTAL_TFFRAMEWORK=1 make testacc TESTS='"AccMackerelAWSIntegration"'
TF_ACC=1 go test -v ./mackerel/... -run "AccMackerelAWSIntegration" -timeout 120m
2024/10/29 16:17:00 [INFO] mackerel: use terraform-plugin-framework based implementation
=== RUN   TestAccMackerelAWSIntegrationIAMRole
=== PAUSE TestAccMackerelAWSIntegrationIAMRole
=== RUN   TestAccMackerelAWSIntegrationCredentials
=== PAUSE TestAccMackerelAWSIntegrationCredentials
=== CONT  TestAccMackerelAWSIntegrationIAMRole
=== CONT  TestAccMackerelAWSIntegrationCredentials
--- PASS: TestAccMackerelAWSIntegrationCredentials (6.27s)
--- PASS: TestAccMackerelAWSIntegrationIAMRole (6.62s)
PASS
ok      github.com/mackerelio-labs/terraform-provider-mackerel/mackerel 7.743s

[tosuke]

The role field accepts a role ID($service_name: $role_name) or null. Empty string is some kind of pathological case and is not supported currently.

[tosuke]

Original schema:

terraform-provider-mackerel/mackerel/resource_mackerel_aws_integration.go

Lines 11 to 69 in 5955898

	var awsIntegrationServiceResourceWithRetireAutomatically = &schema.Resource{
	Schema: map[string]*schema.Schema{
	"enable": {
	Type: schema.TypeBool,
	Optional: true,
	Default: true,
	},
	"role": {
	Type: schema.TypeString,
	Optional: true,
	},
	"excluded_metrics": {
	Type: schema.TypeList,
	Optional: true,
	Elem: &schema.Schema{
	Type: schema.TypeString,
	},
	},
	"retire_automatically": {
	Type: schema.TypeBool,
	Optional: true,
	},
	},
	}
	var awsIntegrationServiceSchemaWithRetireAutomatically = &schema.Schema{
	Type: schema.TypeSet,
	Optional: true,
	MaxItems: 1,
	Elem: awsIntegrationServiceResourceWithRetireAutomatically,
	}
	var awsIntegrationServiceResource = &schema.Resource{
	Schema: map[string]*schema.Schema{
	"enable": {
	Type: schema.TypeBool,
	Optional: true,
	Default: true,
	},
	"role": {
	Type: schema.TypeString,
	Optional: true,
	},
	"excluded_metrics": {
	Type: schema.TypeList,
	Optional: true,
	Elem: &schema.Schema{
	Type: schema.TypeString,
	},
	},
	},
	}
	var awsIntegrationServiceSchema = &schema.Schema{
	Type: schema.TypeSet,
	Optional: true,
	MaxItems: 1,
	Elem: awsIntegrationServiceResource,
	}

[tosuke]

Original schema:

terraform-provider-mackerel/mackerel/resource_mackerel_aws_integration.go

Lines 110 to 150 in 5955898

	Schema: map[string]*schema.Schema{
	"name": {
	Type: schema.TypeString,
	Required: true,
	},
	"memo": {
	Type: schema.TypeString,
	Optional: true,
	},
	"key": {
	Type: schema.TypeString,
	Optional: true,
	Sensitive: true,
	},
	"secret_key": {
	Type: schema.TypeString,
	Optional: true,
	Sensitive: true,
	},
	"role_arn": {
	Type: schema.TypeString,
	Optional: true,
	},
	"external_id": {
	Type: schema.TypeString,
	Optional: true,
	Sensitive: true,
	},
	"region": {
	Type: schema.TypeString,
	Optional: true,
	},
	"included_tags": {
	Type: schema.TypeString,
	Optional: true,
	},
	"excluded_tags": {
	Type: schema.TypeString,
	Optional: true,
	},
	},

[ne-sachirou]

🙆‍♀️