-
-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
README: link to build instructions, slight polish to Markdown #1520
Conversation
Perhaps https://github.com/macvim-dev/macvim/wiki/Building might be a better link. |
Thanks for the PR. For now, it's probably better to link to https://github.com/macvim-dev/macvim/wiki/Building It's definitely my bad that I haven't really updated the README yet. I really need to update the overall documentation of MacVim to make it easier to contribute and understand the overall layout and how to build/test MacVim. Did you have any specific questions or roadblocks? It would be useful to know the issues you encountered other than just general lack of instructions (which is itself an issue…) |
I found it difficult to find the instructions for building MacVim from source, but very easy to build it once I found the instructions. Hopefully, this will help others find these helpful instructions.
Done.
Actually, I had a very good experience, the best by far out of all Mac applications I have tried to compile from source so far (I'm not a MacOS developer, I merely use MacOS to develop). Once I found the instructions, they just worked immediately and I had a ready-to-use app that ran correctly. In my previous attempts (with other projects), I ran into weird library errors, things looking for libraries in wrong homebrew directories, or I at least had to fuss with XCode. I compiled from source mainly wanted to get the fix for #1503 (which also works great BTW, thank you!) early, so I'm not sure I'll actually contribute much, but I'm more likely to become one than before. I don't use Vim as much these days, mostly VS Code or Kakoune. To get nitpicky, one thing that maybe would be nice to add is an explanation of what flags to |
Looks good, merged!
That's a fair point. One thing that should be coming in near future is reproducible builds (#1506) where you can make a build identical to the official release (well, identical other than the digital signature which by definition is not reproducible unless you stole my key). As part of that I would need to include instructions how to build it. But yes it would include a bit more work with setting up Homebrew packages etc (it's more annoying than just installing the right packages as we compile gettext/libsodium manually so they target the right OS versions).
Great! I do want to push a pre-release version out soon as it's been a while since I have made a release. You could opt in to that in the advanced setting (pre-releases are mostly just slightly less polished releases but for the most part should be fine). Otherwise a full release should come in 1-2 months. |
Thanks for the review! No need to rush the (pre)release on my account. |
I found it difficult to find the instructions for building MacVim from source, but very easy to build it once I found the instructions.
Hopefully, this will help others find these helpful instructions.