-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
A few cudacpp plugin changes on the way to madevent integration #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_MEEXPORTER/MEEXPORTER_PBRIDGE
…essIp4IparConst_s
…madevent (eventually require 32)
…adevent makefiles
…_cuda (was _cu) In the madevent integration, this will seem more consistent with the 'cudacpp' plugin name?...
…r in 512z??... ignore for now
Fix conflicts: epochX/cudacpp/CODEGEN/PLUGIN/CUDACPP_SA_OUTPUT/madgraph/iolibs/template_files/gpu/Makefile epochX/cudacpp/ee_mumu.auto/CODEGEN_cudacpp_ee_mumu_log.txt epochX/cudacpp/ee_mumu.auto/SubProcesses/Makefile epochX/cudacpp/ee_mumu/SubProcesses/Makefile epochX/cudacpp/gg_tt.auto/CODEGEN_cudacpp_gg_tt_log.txt epochX/cudacpp/gg_tt.auto/SubProcesses/Makefile epochX/cudacpp/gg_tt/SubProcesses/Makefile (Codegen logs from upstream/master)
…on for madevent, will change .mad generation in v311)
…oing back to 32 threads in GPU
…that is slower??)
…a few fluctuations Note that the discrepancy between check.exe and fcheck.exe is now much lower after fixing the bug! (I was previously comparing check on cpu to fgcheck on GPU, which of course gives different results)
…alone PR before further fixes and PRs...
I am about to merge this PR #416 as a standalone patch. There are very many other changes from myself, Stefan and Olivier that must be integrated, I must start somewhere... The main changes in this PR are the following (git log upstream/master..cc4mad):
|
All checks passed, I am self merging |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP PR with a few changes to the cudacpp plugin, that are needed for the madevent integration (issue #400 et al, PR #401).
I am currently debugging issues in ggtt where I get different MEs in fortran and cudacpp for ggtt. I backported the changes from #401 in ggtt to codegen, so that I can try eemumu too. When all seems settled, I will first merge this PR standalone with all tests in cudacpp internally, before merging the madevent+cudacpp.