Reenable OPENMP multithreading in cudacpp #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nTest.exe linking)
…6 sa I made a few tests manually, see logs in madgraph5#575 NB One thing that I have not done is to reenable OMP tests in tmad/tput scripts. You need very large number of events and long tests to get meaningful results
|
The CI was failing, I needed to fix the patch for the differente API without MULTICHANNEL #568 Now done |
…adgraph5#575 (but clang fails build)
…l revert" This reverts commit 3ec8cf25ecccb9bed2bc450c33f2b4e2c81b7b5b.
…ert" This reverts commit 2b47ccfb99700c0fb4852538fe2e1fb313732362.
Tested ok on gcc112/clang13/icpx2022, all with/without nvcc
…READ if _OPENMP is not defined
…n/madevent software Tested on icpx with/without nvcc
… fix build error about missing intel_fast_copy This and previous timermap/driver/ompnumthreads fixes for openmp are part of the madgraph5#561 patch
… defined, port from ggtt.mad
./CODEGEN/generateAndCompare.sh gg_tt --mad --nopatch git diff --no-ext-diff -R gg_tt.mad/Source/dsample.f gg_tt.mad/Source/genps.inc gg_tt.mad/Source/vector.inc gg_tt.mad/SubProcesses/makefile > CODEGEN/MG5aMC_patches/PROD/patch.common git diff --no-ext-diff -R gg_tt.mad/SubProcesses/P1_gg_ttx/auto_dsig1.f gg_tt.mad/SubProcesses/P1_gg_ttx/driver.f gg_tt.mad/SubProcesses/P1_gg_ttx/matrix1.f > CODEGEN/MG5aMC_patches/PROD/patch.P1 git checkout gg_tt.mad
…ll revert" This reverts commit 25a9d296523717450ed34e68e861327059f4ffdf.
…t nvcc, not ok with nvcc
…n icpx (only partly done, without nvcc)
…graph5#575 (not yet on icpx clang madgraph5#578)
|
And I fixed it again because Apple clang does not start with clang... |
|
Ok the CI finally succeeded including clang/MAC (with omp disabled #578) I wil self merge |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is about #575, it reenables OMP MT in cudacpp