Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support for Arm based Mac's - prevents system monitor (gotty) crash #116

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

SumoSumir
Copy link
Contributor

System-monitor would fall into a crash loop due to invalid gotty architecture download and install.

Screenshot 2023-04-27 at 11 08 33 PM

Screenshot 2023-04-28 at 1 32 45 AM

@SumoSumir
Copy link
Contributor Author

Additionally, please check out this gotty fork recommended by @xingxing. It has better project dependency management.

Ref comment - yudai/gotty#337 (comment)
Fork link - https://github.com/borancar/gotty/tree/feat/go_modules

@madhuakula madhuakula self-requested a review April 27, 2023 20:45
@madhuakula madhuakula added the bug Something isn't working label Apr 27, 2023
@madhuakula
Copy link
Owner

Thank you so much @SumoSumir for the fix, yes indeed as gotty has been not maintained at the main source I will check the alternative approach.

Let me quickly verify the Dockerfile build and test before I merge.

Copy link
Owner

@madhuakula madhuakula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@madhuakula madhuakula merged commit 9c10f8a into madhuakula:master Apr 27, 2023
@madhuakula
Copy link
Owner

I will update the upstream container images and close #115

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants