Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Clean up navigation mode tests #219

Merged
merged 6 commits into from
Jun 11, 2019

Conversation

earshinov
Copy link
Contributor

@earshinov earshinov commented Jun 11, 2019

It makes little sense to have tests for StrictNavigationMode, SemiStrictNavigationMode, FreeNavigationMode after the corresponding classes have been removed in #211

It makes little sense to have tests for StrictNavigationMode, SemiStrictNavigationMode, FreeNavigationMode after the corresponding classes have been removed in madoar#211
@earshinov earshinov changed the title Clean navigation mode tests Clean up navigation mode tests Jun 11, 2019
src/lib/navigation/wizard-navigation-allow-forward.spec.ts Outdated Show resolved Hide resolved
Step 3
</aw-wizard-completion-step>
</aw-wizard>
`,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commas removed in b1cdb91

Step 3
</aw-wizard-step>
</aw-wizard>
`,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commas removed in b1cdb91

@@ -0,0 +1,22 @@
import { WizardComponent } from '../components/wizard.component';

export function checkWizardState(
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some comments to the method

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments added in 33803c7

@madoar madoar merged commit 59777f9 into madoar:develop Jun 11, 2019
@earshinov earshinov deleted the clean-navigation-mode-tests branch June 11, 2019 20:53
@earshinov
Copy link
Contributor Author

@madoar , Regarding collaboration invitation, I am honored, but I cannot accept such responsibility. Among other reasons, I am afraid that at some point in the future we will migrate our project to something like Material and switch to its wizard component, which will turn me off angular-archwizard. I have a short history of abandoning public projects, and would not like to go through such experience again.

@madoar
Copy link
Owner

madoar commented Jun 11, 2019

No problem, I can understand your situation. It is hard to work on a project if you have no current use-case for it, then the project maintenance can become a burden.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants