-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Clean up navigation mode tests #219
Conversation
It makes little sense to have tests for StrictNavigationMode, SemiStrictNavigationMode, FreeNavigationMode after the corresponding classes have been removed in madoar#211
…itable in unit tests
Step 3 | ||
</aw-wizard-completion-step> | ||
</aw-wizard> | ||
`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commas removed in b1cdb91
Step 3 | ||
</aw-wizard-step> | ||
</aw-wizard> | ||
`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commas removed in b1cdb91
@@ -0,0 +1,22 @@ | |||
import { WizardComponent } from '../components/wizard.component'; | |||
|
|||
export function checkWizardState( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some comments to the method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments added in 33803c7
…hat is demanded by Codacy. Add trailing commas where necessary.
@madoar , Regarding collaboration invitation, I am honored, but I cannot accept such responsibility. Among other reasons, I am afraid that at some point in the future we will migrate our project to something like Material and switch to its wizard component, which will turn me off angular-archwizard. I have a short history of abandoning public projects, and would not like to go through such experience again. |
No problem, I can understand your situation. It is hard to work on a project if you have no current use-case for it, then the project maintenance can become a burden. |
It makes little sense to have tests for
StrictNavigationMode
,SemiStrictNavigationMode
,FreeNavigationMode
after the corresponding classes have been removed in #211