Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support [navigateForward]="visited" #228

Merged
merged 3 commits into from
Aug 11, 2019

Conversation

earshinov
Copy link
Contributor

@earshinov earshinov commented Aug 11, 2019

This implements another strategy for forward navigation using the navigation bar in addition to allow and deny. It allows to navigate to a forward step iff the user has visited the step before.

That's a re-implementation of a NavigationMode that we have been using in our project for quite some time. I think it can be useful for other projects as well.

Apart from the code, this MR contains updated unit tests and docs (README).

Shortly I will also prepare a page in the angular-archwizard-demo application.

Copy link
Owner

@madoar madoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I like this PR. I just have a small issue with the naming of the new check method. For more details see below.

src/lib/util/test-utils.ts Outdated Show resolved Hide resolved
@madoar madoar merged commit 70b638d into madoar:develop Aug 11, 2019
@earshinov earshinov deleted the navigate-forward-visited branch August 11, 2019 16:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants