-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Tests: IVY true and false #282
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase this PR against the develop
branch
Will make the changes in a few hours when I get off my work. |
I think that's it. Let me know if you need anything else. |
@hugoj-goncalves thank you for fixing this! I'm currently not sure whether to release a version |
I can't see a reason to wait, as it's broken for people that are not using ivy. but it's totally up to you, I can only thank you for this amazing component ;) |
@madoar, Please-please-please release 6.0.1! We've also come across this problem after upgrading to Angular 9 and aw 6.0.0. |
Ok, I have just released Please give me feedback whether the new version fixes your issue. |
Yes, the issue is fixed after we upgraded to 6.0.1. Thank you very much for a prompt response! |
For me not work and I use Ionic with angular 8 |
Work only if I use this "encapsulation: ViewEncapsulation.None" in my component |
Fixes #278
Tests passed locally.
Demo worked just fine also, with and without IVY