-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
added rtl support #286
added rtl support #286
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please also add an example for this to the Demo Repository?
This would help me a lot with testing this change. In addition I think it would also help other people who want to use right-to-left
direction :)
Slightly off-topic:
Do you think we should retain the navBarDirection
input attribute of the WizardComponent
?
I have made a pr to add rtl example to the demo repo. madoar/angular-archwizard-demo#69 |
@KarimTayie thank you very much for fixing this Issue! I will cherry pick this change to the version |
@madoar Thank you for your excellent guidance and amazing effort put on this repo. |
Please correct me if I am wrong, but I don't think this is an issue in this case because the changes seem to be independent of the whether the "lines" are drawn in the |
@madoar sorry for the late reply as I was very busy lately. |
added rtl support to the latest version.
this pr should solve this issue #280