Allow c_void pointers as return and argument types in more cases (behind a feature flag)
#478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
added
enhancement
madsmtm
changed the title
^v be a valid encoding in more places
|
I'm considering implementing the logic in EDIT: Done. |
madsmtm
changed the title
^v be a valid encoding in more placesc_void pointers as return and argument types in more cases (behind a feature flag)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will help with servo/core-foundation-rs#628, since a lot of CoreFoundation types are used there as just
*mut c_void, and it would be really cumbersome and error-prone to have to change all of these to custom type aliases with a properEncodeimplementation.