Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add rarity filters to deck editor #4306

Merged
merged 1 commit into from
Dec 31, 2017

Conversation

skeate
Copy link
Contributor

@skeate skeate commented Dec 30, 2017

Not sure if anybody besides me would find this useful, but I like it especially for building Pauper decks.

I got the icons from https://github.com/andrewgioia/Keyrune -- I can change them if you'd prefer something else (though I'm no artist)

@JayDi85
Copy link
Member

JayDi85 commented Dec 30, 2017

I have a questions about font license...

It's say: "All set symbol images are copyright Wizards of the Coast" -- is that a real open source resources? E.g. can it be distributed with xmage application (MIT give that) or it can be downloaded like current resources like images and symbols?

@skeate
Copy link
Contributor Author

skeate commented Dec 31, 2017

I'm not 100% sure on the licensing. The font itself is SIL Open Font License which is pretty permissive. But I know most symbols like that are downloaded separately, presumably for licensing issues (energy is a curious exception).

I could try to use the downloaded symbol (though that'll take me a bit more time to figure out) or just change the symbols to a colored box or something.

@LevelX2
Copy link
Contributor

LevelX2 commented Dec 31, 2017

I guess we better avoid all possible image copyright problems. So best change it to other symbols.

@JayDi85
Copy link
Member

JayDi85 commented Dec 31, 2017

I like simple symbols for it like: C, U, R, M, S (text is more user friendly than color).

Draw example (colored and uncolored icons):
shot_171231_151917

If that's fine then I can upload needed png images (any size: 16, 24, 32, 64 px).

P.S. Why it use non standard 20 px icons now?

@skeate
Copy link
Contributor Author

skeate commented Dec 31, 2017

That's a much better idea. I like the letters with colored background. As for the icon size -- I was just matching the other similar buttons in the deck editor. Not sure why they're 20x20

@JayDi85
Copy link
Member

JayDi85 commented Dec 31, 2017

Added new icons in that commit 54e7c3c

@skeate skeate force-pushed the feature/rarity-filters branch from d839007 to 25e354f Compare December 31, 2017 16:54
@skeate
Copy link
Contributor Author

skeate commented Dec 31, 2017

Updated to use those icons

@skeate skeate force-pushed the feature/rarity-filters branch from 25e354f to 32cdd3b Compare December 31, 2017 17:02
@JayDi85 JayDi85 merged commit 34c32a7 into magefree:master Dec 31, 2017
@skeate skeate deleted the feature/rarity-filters branch December 31, 2017 19:27
@JayDi85 JayDi85 added the GUI label Jan 1, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants