-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
bug fixes to make aws pr-test build work same as cicrcle ci #1155
Conversation
Devagouda Patil seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
This pull request is automatically deployed with Now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good 👍
2da34d1
to
874db9e
Compare
874db9e
to
62dc0ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still looking good 👍
491d5e7
to
9871e35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
How to test - Fail conditions -
To test yarn install --frozen-lockfile || exit 1
Change "babel-eslint": "~10.0.1" to "babel-eslint": "~15.0.1" and git Push then observe aws log.
To test yarn run build || exit 1
packages/venia-concept/src/components/SearchBar/stories/searchBar.js make some compilation errors like remove ( and git Push then observe aws log
To test yarn workspace @magento/venia-concept run storybook:build || exit 1
packages/venia-concept/src/components/SearchBar/stories/searchBar.js change import { SearchBar } from '../searchBar'; to import { SearchBar } from '../searchBar/adjshsf'; and git Push then observe aws log
To test yarn run danger packages/venia-concept/src/tests/example.spec.js change expect(true).toBe(true); to expect(true).toBe(false);
Pass Condition -
If there are no errors then "yarn run danger " should exit with status code 0