Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

bug fixes to make aws pr-test build work same as cicrcle ci #1155

Merged
merged 2 commits into from
Apr 24, 2019

Conversation

dpatil-magento
Copy link
Contributor

How to test - Fail conditions -

  1. To test yarn install --frozen-lockfile || exit 1
    Change "babel-eslint": "~10.0.1" to "babel-eslint": "~15.0.1" and git Push then observe aws log.

  2. To test yarn run build || exit 1
    packages/venia-concept/src/components/SearchBar/stories/searchBar.js make some compilation errors like remove ( and git Push then observe aws log

  3. To test yarn workspace @magento/venia-concept run storybook:build || exit 1
    packages/venia-concept/src/components/SearchBar/stories/searchBar.js change import { SearchBar } from '../searchBar'; to import { SearchBar } from '../searchBar/adjshsf'; and git Push then observe aws log

  4. To test yarn run danger packages/venia-concept/src/tests/example.spec.js change expect(true).toBe(true); to expect(true).toBe(false);

Pass Condition -
If there are no errors then "yarn run danger " should exit with status code 0

@magento-cicd2
Copy link

magento-cicd2 commented Apr 22, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Devagouda Patil seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@vercel
Copy link

vercel bot commented Apr 22, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@coveralls
Copy link

coveralls commented Apr 22, 2019

Coverage Status

Coverage remained the same at 77.164% when pulling 9871e35 on aws-pr-test-build-bugfix into 0d812ea on develop.

sharkySharks
sharkySharks previously approved these changes Apr 24, 2019
Copy link
Contributor

@sharkySharks sharkySharks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good 👍

sharkySharks
sharkySharks previously approved these changes Apr 24, 2019
Copy link
Contributor

@sharkySharks sharkySharks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still looking good 👍

Copy link
Contributor

@sharkySharks sharkySharks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dpatil-magento dpatil-magento merged commit 055ccce into develop Apr 24, 2019
@sirugh sirugh added the tooling Related to the developer tooling, including buildpack, webpack plugins, and debug UIs. label May 24, 2019
@dpatil-magento dpatil-magento deleted the aws-pr-test-build-bugfix branch July 25, 2019 15:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
tooling Related to the developer tooling, including buildpack, webpack plugins, and debug UIs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants