Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

bug fixes to make aws pr-test build work same as cicrcle ci #1155

Merged
merged 2 commits into from
Apr 24, 2019
Merged

bug fixes to make aws pr-test build work same as cicrcle ci #1155

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62dc0ac
bug fixes to make aws pr-test build work same as cicrcle ci
dpatil-magento Apr 22, 2019
9871e35
Merge branch 'develop' into aws-pr-test-build-bugfix
dpatil-magento Apr 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions .bin/pr-checks
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,14 @@ message () {
echo "==========================================================================="
echo ""
}
STATUS=0

message "Installing dependencies with yarn..."
yarn install --frozen-lockfile
yarn install --frozen-lockfile || exit 1

# production build - needed for some of the subsequent checks, like storybook
message "Running production build..."
cp ./docker/.env.docker.prod ./packages/venia-concept/.env
yarn run build
yarn run build || exit 1

# jest tests - does not fail ci, failures are evaluated by danger check below
message "Running unit tests with Jest..."
Expand All @@ -28,14 +27,11 @@ message "Running Coveralls..."
yarn run coveralls

message "Running Storybook..."
yarn workspace @magento/venia-concept run storybook:build
yarn workspace @magento/venia-concept run storybook:build || exit 1

message "Running Bundlesize..."
yarn run bundlesize

# danger ci - eslint, prettier:validate, unit test evaluation, etc.
message "Running Danger..."
yarn run danger || STATUS=$?

echo "Exit Status: $STATUS"
exit $STATUS
yarn run danger