-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fix the issue #39944
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: 2.4-develop
Are you sure you want to change the base?
Fix the issue #39944
Conversation
Hi @iranimij. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
@iranimij, could you please provide more details? Which error are you getting? What are the steps to reproduce? |
@ihor-sviziev The issue is exactly the same as the one we had here: #37187, but the solution did not fix the issue. I have a solution that fixes the issue. as far as I checked \Magento\TestFramework\App\Config\Interceptor does not implement |
@magento run all tests |
@@ -127,7 +127,7 @@ public function reinitStores() | |||
//In order to restore configFixture values | |||
$testAppConfig = ObjectManager::getInstance()->get(Config::class); | |||
$reflection = new \ReflectionClass($testAppConfig); | |||
if ($reflection->implementsInterface(InterceptorInterface::class)) { | |||
if ($reflection->implementsInterface(ScopeConfigInterface::class)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this check for ScopeConfigInterface
OR InterceptorInterface
? We need to make sure this works for the case, where there is a plugin defined, but also if there is no plugin.
@iranimij, I see it was tested in #37187 (comment), and looked as a working solution. Could you please clarify, if the steps are absolutely the same? |
@ihor-sviziev I found out that it happens when the module : |
@iranimij, then it looks like a bug in the https://github.com/creatuity/magento2-interceptors, because interceptors should implement the InterceptorInterface. |
This PR #37187 didn't fix the interceptor issue. Since the reflection class implements
ScopeConfigInterface
so I updated it to fix the condition.