Skip to content

Commit

Permalink
Style icons with CSS (#2272)
Browse files Browse the repository at this point in the history 
* Refactor icon style

* Update snapshots

* Fix icon classnames and prop types

* Update quantity stepper and kebab icons

* Fix filter and sort icons

* Fix disabled pagination buttons

* Fix pagination css

Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com>
  • Loading branch information
@jimbo @dpatil-magento
jimbo and dpatil-magento authored Apr 1, 2020
1 parent be66a41 commit 25e8d20
Show file tree
Hide file tree
Showing 34 changed files with 464 additions and 465 deletions.
2 changes: 2 additions & 0 deletions packages/venia-ui/lib/components/Accordion/__tests__/__snapshots__/accordion.spec.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ exports[`it renders a closed Section correctly 1`] = `
className="root"
>
<svg
className="icon"
fill="none"
height="24"
stroke="currentColor"
Expand Down Expand Up @@ -72,6 +73,7 @@ exports[`it renders an open Section correctly 1`] = `
className="root"
>
<svg
className="icon"
fill="none"
height="24"
stroke="currentColor"
Expand Down
16 changes: 8 additions & 8 deletions packages/venia-ui/lib/components/App/__tests__/__snapshots__/app.spec.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -737,7 +737,7 @@ ReactTestInstance {
"calls": Array [
Array [
Object {
"icon": <Classify(Icon)
"icon": <Icon
attrs={
Object {
"width": 18,
Expand Down Expand Up @@ -772,7 +772,7 @@ Debug: 1 1",
"calls": Array [
Array [
Object {
"icon": <Classify(Icon)
"icon": <Icon
attrs={
Object {
"width": 18,
Expand Down Expand Up @@ -807,7 +807,7 @@ Debug: 1 1",
"calls": Array [
Array [
Object {
"icon": <Classify(Icon)
"icon": <Icon
attrs={
Object {
"width": 18,
Expand Down Expand Up @@ -842,7 +842,7 @@ Debug: 1 1",
"calls": Array [
Array [
Object {
"icon": <Classify(Icon)
"icon": <Icon
attrs={
Object {
"width": 18,
Expand Down Expand Up @@ -2923,7 +2923,7 @@ ReactTestInstance {
"calls": Array [
Array [
Object {
"icon": <Classify(Icon)
"icon": <Icon
attrs={
Object {
"width": 18,
Expand Down Expand Up @@ -2958,7 +2958,7 @@ Debug: undefined undefined",
"calls": Array [
Array [
Object {
"icon": <Classify(Icon)
"icon": <Icon
attrs={
Object {
"width": 18,
Expand Down Expand Up @@ -2993,7 +2993,7 @@ Debug: undefined undefined",
"calls": Array [
Array [
Object {
"icon": <Classify(Icon)
"icon": <Icon
attrs={
Object {
"width": 18,
Expand Down Expand Up @@ -3028,7 +3028,7 @@ Debug: undefined undefined",
"calls": Array [
Array [
Object {
"icon": <Classify(Icon)
"icon": <Icon
attrs={
Object {
"width": 18,
Expand Down
8 changes: 8 additions & 0 deletions ...rtPage/PriceAdjustments/ShippingMethods/__tests__/__snapshots__/shippingForm.spec.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ Array [
className="root"
>
<svg
className="icon"
fill="none"
height={18}
stroke="currentColor"
Expand Down Expand Up @@ -251,6 +252,7 @@ Array [
className="root"
>
<svg
className="icon"
fill="none"
height={18}
stroke="currentColor"
Expand Down Expand Up @@ -441,6 +443,7 @@ Array [
className="root"
>
<svg
className="icon"
fill="none"
height={18}
stroke="currentColor"
Expand Down Expand Up @@ -523,6 +526,7 @@ Array [
className="root"
>
<svg
className="icon"
fill="none"
height={18}
stroke="currentColor"
Expand Down Expand Up @@ -673,6 +677,7 @@ Array [
className="root"
>
<svg
className="icon"
fill="none"
height={18}
stroke="currentColor"
Expand Down Expand Up @@ -755,6 +760,7 @@ Array [
className="root"
>
<svg
className="icon"
fill="none"
height={18}
stroke="currentColor"
Expand Down Expand Up @@ -895,6 +901,7 @@ Array [
className="root"
>
<svg
className="icon"
fill="none"
height={18}
stroke="currentColor"
Expand Down Expand Up @@ -977,6 +984,7 @@ Array [
className="root"
>
<svg
className="icon"
fill="none"
height={18}
stroke="currentColor"
Expand Down
2 changes: 2 additions & 0 deletions ...mponents/CartPage/ProductListing/EditModal/__tests__/__snapshots__/editModal.spec.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ exports[`renders closed shell with no active item 1`] = `
className="root"
>
<svg
className="icon"
fill="none"
height="24"
stroke="currentColor"
Expand Down Expand Up @@ -72,6 +73,7 @@ exports[`renders open drawer with active item 1`] = `
className="root"
>
<svg
className="icon"
fill="none"
height="24"
stroke="currentColor"
Expand Down
94 changes: 44 additions & 50 deletions ...onents/CartPage/ProductListing/EditModal/__tests__/__snapshots__/productForm.spec.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -46,30 +46,27 @@ exports[`renders form with data 1`] = `
type="button"
>
<span
className="content"
className="root"
>
<span
className="root"
<svg
className="icon"
fill="none"
height={22}
stroke="currentColor"
strokeLinecap="round"
strokeLinejoin="round"
strokeWidth="2"
viewBox="0 0 24 24"
width={22}
xmlns="http://www.w3.org/2000/svg"
>
<svg
fill="none"
height={22}
stroke="currentColor"
strokeLinecap="round"
strokeLinejoin="round"
strokeWidth="2"
viewBox="0 0 24 24"
width={22}
xmlns="http://www.w3.org/2000/svg"
>
<line
x1="5"
x2="19"
y1="12"
y2="12"
/>
</svg>
</span>
<line
x1="5"
x2="19"
y1="12"
y2="12"
/>
</svg>
</span>
</button>
<span
Expand Down Expand Up @@ -115,36 +112,33 @@ exports[`renders form with data 1`] = `
type="button"
>
<span
className="content"
className="root"
>
<span
className="root"
<svg
className="icon"
fill="none"
height={20}
stroke="currentColor"
strokeLinecap="round"
strokeLinejoin="round"
strokeWidth="2"
viewBox="0 0 24 24"
width={20}
xmlns="http://www.w3.org/2000/svg"
>
<svg
fill="none"
height={22}
stroke="currentColor"
strokeLinecap="round"
strokeLinejoin="round"
strokeWidth="2"
viewBox="0 0 24 24"
width={22}
xmlns="http://www.w3.org/2000/svg"
>
<line
x1="12"
x2="12"
y1="5"
y2="19"
/>
<line
x1="5"
x2="19"
y1="12"
y2="12"
/>
</svg>
</span>
<line
x1="12"
x2="12"
y1="5"
y2="19"
/>
<line
x1="5"
x2="19"
y1="12"
y2="12"
/>
</svg>
</span>
</button>
</div>
Expand Down
Loading

0 comments on commit 25e8d20

Please # to comment.