Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[bug]: If user tries to access product page after it goes to out of stock then system enters a infinite loop. #1159

Closed
dpatil-magento opened this issue Apr 23, 2019 · 1 comment · Fixed by #1229
Closed

[bug]: If user tries to access product page after it goes to out of stock then system enters a infinite loop. #1159

dpatil-magento opened this issue Apr 23, 2019 · 1 comment · Fixed by #1229
Assignees
@supernova-at
Labels
bug Something isn't working

Comments

@dpatil-magento
Copy link
Contributor

dpatil-magento commented Apr 23, 2019 •
edited
Loading

Steps -

  1. Access a product details page say for Product A.
  2. Login to backend and make Product A as out of stock.
  3. Now either refresh the product details page on storefront venia or try accessing the product again.

Expected - System should throw error message indicating product not available.
Actual - System show error notification and if user click on in the same error re-appears. User has to clear browser cache to make it work.

Screen -
image.png
@dpatil-magento dpatil-magento added the bug Something isn't working label Apr 23, 2019
@dpatil-magento dpatil-magento changed the title [bug]: If user tries to access product page after it goes to out of stock then system enters in infinite loop. [bug]: If user tries to access product page after it goes to out of stock then system enters a infinite loop. Apr 23, 2019
@sudeep-cedcoss
Copy link
Contributor

I am working on this at #dmcdindia1

sudeep-cedcoss added a commit to sudeep-cedcoss/pwa-studio that referenced this issue May 9, 2019
@sudeep-cedcoss
Fixed magento#1159
f46431d 
Fixed magento#1159 [bug]: If user tries to access product page after it goes to out of stock then system enters a infinite loop.
@sudeep-cedcoss sudeep-cedcoss mentioned this issue May 9, 2019
Merged
5 tasks
dpatil-magento pushed a commit that referenced this issue Jun 6, 2019
@sudeep-cedcoss @dpatil-magento
Product Out of Stock Message (#1229)
5544164 
* Fixed #1159 

Fixed #1159 [bug]: If user tries to access product page after it goes to out of stock then system enters a infinite loop.

* Updates Product to show out of stock message when appropriate

* Adds Unit Tests to ErrorView
@supernova-at supernova-at mentioned this issue Jul 23, 2019
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@supernova-at supernova-at

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Product Out of Stock Message sudeep-cedcoss/pwa-studio
3 participants
@supernova-at @sudeep-cedcoss @dpatil-magento