Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

documentation: Corrected media path variables #1000

Merged
merged 6 commits into from
Mar 25, 2019
Merged

documentation: Corrected media path variables #1000

merged 6 commits into from
Mar 25, 2019

Conversation

yogeshsuhagiya
Copy link
Member

Description

  • Correct the name of media path environment variables for the product & category.

Checklist:

  • I have read the CONTRIBUTING document.
  • I have linked an issue to this PR.
  • I have indicated the change type and relevant package(s).
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All CI checks are green (linting, build/deploy, etc).
  • At least one core contributor has approved this PR.

@vercel
Copy link

vercel bot commented Mar 7, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

sirugh
sirugh previously approved these changes Mar 11, 2019
View reviewed changes
Copy link
Contributor

@sirugh sirugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sirugh sirugh added the bug Something isn't working label Mar 11, 2019
@sirugh sirugh changed the title Corrected media path variables bugfix: Corrected media path variables Mar 11, 2019
@coveralls
Copy link

coveralls commented Mar 11, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 76.633% when pulling fad00af on yogeshsuhagiya:develop-PR-yogesh-1 into 850c3e6 on magento-research:develop.

@yogeshsuhagiya
Copy link
Member Author

@sirugh Is there anything that needs from my side?

@yogeshsuhagiya
Copy link
Member Author

Hi @sirugh, It has been 10+ days but still no progress with this PR. Can you please check?

@sirugh
Copy link
Contributor

sirugh commented Mar 18, 2019

@yogeshsuhagiya we've been actively working on getting our 2.1.0 release out the door. We've also got a big backlog of other pull requests to prioritize, review, qa, etc. It's a lot of work for a small team to handle. While we love to see community contributions they may not be at the top of our "to-do" list. Your patience is greatly appreciated.

@yogeshsuhagiya
Copy link
Member Author

Hi @sirugh, sorry but how many more days I've to wait? The 2.1.0 version already released but still no progress.

@sirugh sirugh changed the title bugfix: Corrected media path variables documentation: Corrected media path variables Mar 25, 2019
@sirugh sirugh added the documentation This pertains to documentation. label Mar 25, 2019
@sirugh
Copy link
Contributor

sirugh commented Mar 25, 2019

This was already fixed in #1039 but the doc/comment portion of .env.dist was not updated. 👍

@sirugh sirugh merged commit 09cea02 into magento:develop Mar 25, 2019
@sirugh sirugh added the version: Patch This changeset includes backwards compatible bug fixes. label May 24, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sirugh sirugh sirugh left review comments

Assignees

@tjwiebell tjwiebell

Labels
bug Something isn't working documentation This pertains to documentation. version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Milestone
Next PWA Release (Core 2.3.2)
Development

Successfully merging this pull request may close these issues.
6 participants
@yogeshsuhagiya @coveralls @sirugh @tjwiebell @cherdman @supernova-at