-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Hide menu from navigation if disabled from Magento admin #1022
Conversation
This pull request is automatically deployed with Now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test for the case where include_in_menu
is falsy.
I've added a test for the case where |
@sirugh I've added a test case where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the test case!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the unit tests and was about to merge, but found a minor coercion problem that was worth sending back your way. Should be good to go after that change.
Category hide from navigation menu, if "Include in Menu" attribute set to false from Magento admin.
Description
Added field in graphql schema and added condition to hide menu from navigation.
Related Issue
Closes #1021
Motivation and Context
Verification
Screenshots (if appropriate):
Magento Configuration:

Before Fixed:

After Fixed:

Proposed Labels for Change Type/Package
BUG
venia-concept
Checklist: