Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(ci): Configure CircleCI to build release and master. #1043

Merged
merged 1 commit into from
Mar 20, 2019
Merged

fix(ci): Configure CircleCI to build release and master. #1043

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,17 @@ workflows:
version: 2
build-deploy:
jobs:
- build:
- pr:
filters:
branches:
ignore: master
- master:
ignore: &integration_branches
- master
- develop
- /release\/\d+\.\d+
- integration:
filters:
branches:
only: master
only: *integration_branches
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does CircleCI know what integration_branches are?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a back reference to the array above on L9.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a YAML anchor reference to the YAML anchor defined above with &integration_branches.


# This key means nothing to CircleCI; it's just a place to keep anchored
# configuration nodes for reuse.
Expand Down Expand Up @@ -42,7 +45,7 @@ common_settings:
path: "packages/venia-concept/dist"

jobs:
master:
integration:
docker: *docker_setup
steps:
- checkout
Expand All @@ -55,9 +58,13 @@ jobs:
command: yarn run coveralls
- run: *full_build
- run: *storybook_build
- run:
name: Bundle size analysis
command: yarn run bundlesize

- store_test_results: *test_result_path
- store_artifacts: *artifact_storage_path
build:
pr:
docker: *docker_setup
steps:
- checkout
Expand Down