Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Updates PR Template to include Version label #1048

Merged
merged 2 commits into from
Mar 25, 2019
Merged

Updates PR Template to include Version label #1048

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
404580a
Updates PULL_REQUEST_TEMPLATE.md to include a checklist item for addi…
supernova-at Mar 21, 2019
9596775
Merge branch 'develop' into supernova/1047-add_version_label_to_pr_te…
tjwiebell Mar 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Closes #ISSUE_NUMBER.
<!--- Why is this change required? What problem does it solve? -->


## Verification
## Verification Steps
<!-- Please describe in detail how a reviewer can verify your changes. -->


Expand All @@ -39,7 +39,7 @@ Closes #ISSUE_NUMBER.
<!--- see how your change affects other areas of the code, etc. -->


## Screenshots (if appropriate):
## Screenshots / Screen Captures (if appropriate):


## Proposed Labels for Change Type/Package
Expand All @@ -57,8 +57,9 @@ Closes #ISSUE_NUMBER.
- [ ] I have read the **CONTRIBUTING** document.
- [ ] I have linked an issue to this PR.
- [ ] I have indicated the change type and relevant package(s).
- [ ] I have updated the documentation accordingly.
- [ ] I have added tests to cover my changes.
- [ ] I have proposed a change level by adding one of the `version: Major`, `version: Minor`, or `version: Patch` labels based on the defined [Public API](https://magento-research.github.io/pwa-studio/technologies/versioning/).
- [ ] I have updated the documentation accordingly, if necessary.
- [ ] I have added tests to cover my changes, if necessary.
- [ ] All new and existing tests passed.
- [ ] All CI checks are green (linting, build/deploy, etc).
- [ ] At least one core contributor has approved this PR.